Skip to content

Conversation

@nateProjects
Copy link

This update improves compatibility with modern macOS versions including Big Sur (11), Monterey (12), Ventura (13), Sonoma (14), and Sequoia (15).

Key changes:

  • Fixed CPU detection to retrieve full brand string instead of just first word
  • Improved Apple Silicon detection using regex pattern matching (^Apple)
  • Fixed critical macOS version detection bug for 11+ versions
    • Previous code broke with new versioning scheme (11.x vs 10.x)
    • Now properly handles both old (10.x) and new (11+) version formats
  • Added comprehensive comments documenting macOS version/shell relationships
  • Verified all Homebrew formulas remain valid and maintained

The version detection fix resolves an issue where the uninstall function would incorrectly determine the default shell for macOS 11+ systems.

claude and others added 2 commits November 11, 2025 14:45
This update improves compatibility with modern macOS versions including
Big Sur (11), Monterey (12), Ventura (13), Sonoma (14), and Sequoia (15).

Key changes:
- Fixed CPU detection to retrieve full brand string instead of just first word
- Improved Apple Silicon detection using regex pattern matching (^Apple)
- Fixed critical macOS version detection bug for 11+ versions
  * Previous code broke with new versioning scheme (11.x vs 10.x)
  * Now properly handles both old (10.x) and new (11+) version formats
- Added comprehensive comments documenting macOS version/shell relationships
- Verified all Homebrew formulas remain valid and maintained

The version detection fix resolves an issue where the uninstall function
would incorrectly determine the default shell for macOS 11+ systems.
@nateProjects nateProjects marked this pull request as draft November 11, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants